You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Adds initialFocusSkip option to focus-trap - #3163
Adds a new option to focus-trap that allows one to define elements that should avoid being the initial focused element when a focus trap initializes. I've added it as a new option so that the feature is opt-in and the regular behaviour should remain unchanged. I'm also open to other approaches but thought a proof of concept would help.
⛳️ Current behavior (updates)
the initial focused element in focus-trap must be manually specified.
🚀 New behavior
elements can now be marked to avoid being the initial focused elements - allowing elements like tooltips or other elements with distracting focused states to mark themselves as preferring not to be initially focused.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
In the next release, this lands as data-no-autofocus / data-autofocus on getInitialFocus, with dialog/drawer wired through that helper instead of initialFocusSkip on focus-trap.
Thanks for the PR. Closing based on that approach.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3161
📝 Description
Adds a new option to focus-trap that allows one to define elements that should avoid being the initial focused element when a focus trap initializes. I've added it as a new option so that the feature is opt-in and the regular behaviour should remain unchanged. I'm also open to other approaches but thought a proof of concept would help.
⛳️ Current behavior (updates)
the initial focused element in focus-trap must be manually specified.
🚀 New behavior
elements can now be marked to avoid being the initial focused elements - allowing elements like tooltips or other elements with distracting focused states to mark themselves as preferring not to be initially focused.
💣 Is this a breaking change (Yes/No):
No